Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vampiro aint vegan! #85

Closed
mikeyhogarth opened this issue Jun 20, 2019 · 0 comments · Fixed by #90
Closed

Vampiro aint vegan! #85

mikeyhogarth opened this issue Jun 20, 2019 · 0 comments · Fixed by #90
Labels
bug Something isn't working data This is to do with the data rather than being a bug good first issue Good for newcomers question Further information is requested

Comments

@mikeyhogarth
Copy link
Owner

mikeyhogarth commented Jun 20, 2019

Vampiro has honey in, so not vegan, but none of its "ingredients" are marked as vegan - the honey is a "special" and we don't pick up any meta data for those (it's just meant to cover "weird stuff" that whilst technically an ingredient, isn't necessarily something you'd have in your "bar")

We have a number of approaches;

  1. We could promote honey to an ingredient. This would mean it showed up in the "bar", which might not be what we want.
  2. We could put in the ability to mark "special" things as vegan - I don't really like this idea though as this means we'd have two different places to mark things as vegan.
  3. We could deprecate the idea of "special" completely, promote all things to "ingredient" - at which point they'd all show up in the "bar"/"filter" - BUT we could mark them as "special" in ingredients.json to stop that happening.

I like the sound of (3) personally- these "special" types have been the cause of most of you data problems and most of them are gone now anyway - but need to run it past @laurahogarth

@mikeyhogarth mikeyhogarth added bug Something isn't working good first issue Good for newcomers question Further information is requested data This is to do with the data rather than being a bug labels Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data This is to do with the data rather than being a bug good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant