-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg_resources.ContextualVersionConflict: urllib3, requests #229
Comments
I think it's because the latest urllib3 version https://github.com/kennethreitz/requests/issues/5067 |
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue mikf#229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Wouldn't be necessary if pip would do proper version management. As things are right now, pip ignores the urllib3 version requirements from requests because gallery-dl is specifying its own.
Setting a maximum version for urllib3 (and requests) fixed it. Would be nice if pip could respect gallery-dl's and request's version requirements at the same time. Also: why does a Python snap do version checks at run-time, but not during build-time? (rhetorical question) |
Hello Mike,
Mike Fährmann writes:
[...]
Setting a maximum version for urllib3 (and requests) fixed it. Would be nice if pip could respect gallery-dl's and request's version requirements at the same time.
[...]
Can you please elaborate the rationale behind that? Why does urllib3
1.24.[12] fails to download on Windows?
AFAICT gallery-dl 1.8.2 works fine with urllib 1.24.2 and in my
experience most of the times setting an upper version is harmful
for packaging.
Thank you!
|
urllib3 1.24.1 & 1.24.2 cause some issues with
So I added some version specification to setup,py and requirements.txt to exclude those faulty versions (c35217e), but that causes pip to ignore the version specification from I'm going to wait until |
This ensure snap build-time and run-time problems will be noticed more promptly by the maintainers, like issue #229. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Cloudflare now also checks the client's SSL/TLS cipher capabilities and produces a 403: Forbidden response with CAPTCHA if they are insufficient. This commit replaces the default cipher list in urllib3 < 1.25 with the one from 1.25 (1), which doesn't cause problems as long as the client platform actually supports these ciphers. On some platforms (tested with Python 3.4 on Linux and Python 3.7 on an outdated Windows 7 VM) it is necessary to install pyOpenSSL to get everything to work. Explicitly setting a minimum/maximum version for urllib3 is also no longer necessary and installing gallery-dl will therefore not pull a incompatible urllib3 version (#229) Fixes the "403: Forbidden" error on Artstation (#227) (1) urllib3/urllib3@0cedb3b
I've managed to figure out why urllib3 1.24.1 and 1.24.2 (as well as older versions) caused some issues and built a workaround for it (35f3432). Version requirements for urllib3 have been removed and incompatibilities between requests and urllib3 in Snaps should no longer happen. |
Hello Mike,
Mike Fährmann writes:
I've managed to figure out why urllib3 1.24.1 and 1.24.2 (as well as older versions) caused some issues and built a workaround for it (35f3432).
Version requirements for urllib3 have been removed and incompatibilities between requests and urllib3 in Snaps should no longer happen.
Wow! Great catch!
Thank you very much!
|
The edge channel snap crashes when launching with the following message:
I suspect the c35217e commit causes this error, can you check it out?
I'll implement a CI test to catch this kind of runtime error more promptly.
The text was updated successfully, but these errors were encountered: