Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support snap building and simple testrun in Travis CI #231

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

brlin-tw
Copy link
Contributor

This PR should only be merged after #230 as the snap needs to target Ubuntu 16.04.

This ensure snap build-time and run-time problems will be noticed more
promptly by the maintainers, like issue #229.

Signed-off-by: 林博仁(Buo-ren Lin) Buo.Ren.Lin@gmail.com

This ensure snap build-time and run-time problems will be noticed more
promptly by the maintainers, like issue mikf#229.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
@mikf
Copy link
Owner

mikf commented Apr 29, 2019

Failed to fetch stage packages: Error downloading packages for part 'ffmpeg': The package 'libavresample3' was not found..

Is this error going to "fix itself" once #230 is merged?

@brlin-tw
Copy link
Contributor Author

brlin-tw commented Apr 30, 2019

Failed to fetch stage packages: Error downloading packages for part 'ffmpeg': The package 'libavresample3' was not found.

Is this error going to "fix itself" once #230 is merged?

Yes, that error occurs due to the fact that the libavresample3 package only exist in Ubuntu 18.04, but not Ubuntu 16.04 where the CI job runs on.

You can check out the CI job used for patch verification here: https://travis-ci.com/Lin-Buo-Ren/gallery-dl/jobs/196128446

@mikf mikf merged commit 8acbe86 into mikf:master Apr 30, 2019
@brlin-tw brlin-tw deleted the patch/impl-ci-snap-test branch April 30, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants