Error Toast UI

[mikhael28]

I don't know what it is, but I just don't like the errorToast notification UI. Can somebody give some practical suggestions/inspirations for us to rework this?

Edit: the UI looks a little better now with thinner buttons, but still not a great experience.

[shubhankarb180]

We could create it as a modal where we center the error container with grey blurred background. It would better implementation.

[mikhael28]

@shubhankarb180 that sounds great to me. If you can work on this, can you find a way to re-purpose the Modal.js component in src/components? Perhaps we can use it for both the terms of service and this, and we pass in some functions as props, so that it can be used in multiple use cases. Let me know if that makes sense?

[shubhankarb180]

Give me sometime . I need to review the code and flow to see how modal.js is being used. Once I figure that out will comment if we can re-purpose it. Sounds good ? Also can you please tell me where exactly modal.js is being used . So that I check it out once for use case purpose ??

[mikhael28]

The modal.js is being used in the Terms of Service component! You can always do global search command + shift + f and search for components/Modal to understand where that component is being imported from. Let me know if you have any other questions!

[shubhankarb180]

@mikhael28 , just got super busy with work. Will work on this issue on weekend. Sounds good ?

[mikhael28]

@shubhankarb180 that sounds good, I'm assigning this ticket to you!

[shubhankarb180]

@mikhael28 Can you please reassign the issue to someone else ? I tried to work on it but not successful. Will try to work on other issues

[mikhael28]

Okay, that sounds good! Any idea what you want to start with?

[shubhankarb180]

I am currently looking at the queue and seeing if anything is pending that I can get started with. Let me check and will surely comment on that. In the mean time, if you find anything you want to assign , please let me know . I actually have been busy with work as I had work on weekend as well so will try and look in the issues queue now

[mikhael28]

Perhaps @shubhankarb180 you can help us with localization/internationalization - do you speak any languages fluently apart from English? We have @CoDigo93 working on Brazilian/Portugese right now, as per this ticket: #63

[shubhankarb180]

I speak only english as of now. Have planned to learn one more language but later 😊. But will find one issue to work on .

[mikhael28]

@jayeclark I’m going to close this issue, as you have addressed a part of the issue with your previous PR. The ultimate goal, is to replace the react-toastify package (which currently takes up 50kb of space in the application bundle) with a piece of functionality in MUI/elsewhere. For now though, I’m closing :)