Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryLength() and isEmptyQuery() returning incorrect values #39

Closed
dudeOFprosper opened this issue Mar 7, 2019 · 4 comments
Closed
Assignees

Comments

@dudeOFprosper
Copy link
Contributor

Example: https://codesandbox.io/s/1wzz6nr0j4?fontsize=14

queryLength is not searching the query, but is searching the whole URL object instead. This is also causing isEmptyQuery to return an incorrect value.

This should be an easy fix, but I wanted to confirm that this is indeed a bug before going ahead and making a PR for it.

@Mikhus
Copy link
Owner

Mikhus commented Mar 9, 2019

This definitely seems to be a bug as I can see it. I'd be very appreciated for PR if you can do that. Thank you for contributing!

@dudeOFprosper
Copy link
Contributor Author

@Mikhus Thanks for confirming. I will definitely open a PR for it!

@Mikhus
Copy link
Owner

Mikhus commented Mar 10, 2019

Thank you @dudeOFprosper !
Seems now it looks fixed. New version 2.1.11 is published. Could you, please, verify and close this issue if everything is OK?

@dudeOFprosper
Copy link
Contributor Author

It has been fixed @Mikhus! Thanks for double checking it for me and the quick replies.

@Mikhus Mikhus closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants