Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appveyor integration #12

Closed
viciious opened this issue May 6, 2019 · 7 comments
Closed

Add Appveyor integration #12

viciious opened this issue May 6, 2019 · 7 comments

Comments

@viciious
Copy link
Contributor

viciious commented May 6, 2019

I have troubles compiling the master branch in appveyor due to the following error:

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vector(1889): error C2036: 'Rocket::Core::Transforms::Primitive *': unknown size [C:\projects\librocket\Build\RocketCore.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vector(1872): note: while compiling class template member function 'bool std::vector<Rocket::Core::Transforms::Primitive,std::allocator<_Ty>>::_Buy(const unsigned int)'
          with
          [
              _Ty=Rocket::Core::Transforms::Primitive
          ]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vector(735): note: see reference to function template instantiation 'bool std::vector<Rocket::Core::Transforms::Primitive,std::allocator<_Ty>>::_Buy(const unsigned int)' being compiled
          with
          [
              _Ty=Rocket::Core::Transforms::Primitive
          ]
  c:\projects\librocket\include\rocket\core\Transform.h(83): note: see reference to class template instantiation 'std::vector<Rocket::Core::Transforms::Primitive,std::allocator<_Ty>>' being compiled
          with
          [
              _Ty=Rocket::Core::Transforms::Primitive
          ]
@viciious
Copy link
Contributor Author

viciious commented May 6, 2019

The compiler error looks legit to me. I think that forward declaring a type and then using it as a field or as an array primitive is undefined behaviour.

@mikke89
Copy link
Owner

mikke89 commented May 6, 2019

Forward declaring it is fine as long as the underlying type is not used. We could solve this by declaring all the destruct/copy/move/destruct members of the parent class, but we might as well just include the header to solve it.

@mikke89 mikke89 closed this as completed in 87e89c6 May 6, 2019
@mikke89
Copy link
Owner

mikke89 commented May 6, 2019

Does this mean you are giving the C++17 version a go? :)

@viciious
Copy link
Contributor Author

viciious commented May 7, 2019

no, why? :P

@viciious
Copy link
Contributor Author

viciious commented May 7, 2019

I'm getting the following issues now:

ElementInfo.obj : error LNK2019: unresolved external symbol "class Rocket::Core::StringBase<char> __cdecl Rocket::Core::ToString(class Rocket::Core::Transform const &)" (?ToString@Core@Rocket@@YA?AV?$StringBase@D@12@AEBVTransform@12@@Z) referenced in function "public: static bool __cdecl Rocket::Core::TypeConverter<class std::shared_ptr<class Rocket::Core::Transform>,class Rocket::Core::StringBase<char> >::Convert(class std::shared_ptr<class Rocket::Core::Transform> const &,class Rocket::Core::StringBase<char> &)" (?Convert@?$TypeConverter@V?$shared_ptr@VTransform@Core@Rocket@@@std@@V?$StringBase@D@Core@Rocket@@@Core@Rocket@@SA_NAEBV?$shared_ptr@VTransform@Core@Rocket@@@std@@AEAV?$StringBase@D@23@@Z) [C:\projects\librocket\Build\RocketDebugger.vcxproj]
ElementDataGridRow.obj : error LNK2019: unresolved external symbol "public: static double __cdecl Rocket::Core::Clock::GetElapsedTime(void)" (?GetElapsedTime@Clock@Core@Rocket@@SANXZ) referenced in function "public: bool __cdecl Rocket::Controls::ElementDataGridRow::UpdateChildren(void)" (?UpdateChildren@ElementDataGridRow@Controls@Rocket@@QEAA_NXZ) [C:\projects\librocket\Build\RocketControls.vcxproj]

@viciious
Copy link
Contributor Author

viciious commented May 7, 2019

Please do not close unresolved issues

#13

@mikke89
Copy link
Owner

mikke89 commented May 7, 2019

You're right, thank you! Still learning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants