-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging modal documents #642
Comments
Thanks for reporting, I see that the debugger doesn't receive focus when another document has modal focus. Another workaround that seemed to work for me is to make a separate context for the debugger. Better than dealing with workarounds though, I took a stab at properly fixing this. Could you help test this branch and see how it works for you (and checking for no regressions), cheers: https://github.com/mikke89/RmlUi/commits/debugger-modal/ |
Thanks, I will test this out when I have time to port us over to master. We're still using an older version internally (5.x) and haven't upgraded to the current master 6.x yet since we are using some of my PRs that haven't been merged in yet, so it may be a little bit before I can test this myself. I need to get to re-opening those! EDIT: actually I'll do this now. The main issue I ran into trying to get this to compile is TextInputContent.h has a wrong #include directive; the rest of the project uses relative includes, but for some reason this one is absolute & checking system includes:
Using this worked, though:
|
Confirmed fixed with the given branch though; thanks! |
Thanks for testing! Merged to master just now, should be fixed in 263328a. |
If a document is loaded with the Modal flag, it can't be debugged with Rml::Debugger as the modal eats all of the inputs. Currently the only workaround I can spot is just removing Modal when the debugger is visible.
The text was updated successfully, but these errors were encountered: