Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrator): allow disabling logging via migrations.silent #4182

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

AnimeshRy
Copy link
Contributor

@AnimeshRy AnimeshRy commented Mar 29, 2023

This provides an option to make the migration logs silent.

Closes #4124

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d714ccc) 99.70% compared to head (a98fba2) 99.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4182   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         214      214           
  Lines       13931    13933    +2     
  Branches     3267     3269    +2     
=======================================
+ Hits        13890    13892    +2     
  Misses         40       40           
  Partials        1        1           
Impacted Files Coverage Δ
packages/core/src/utils/Configuration.ts 100.00% <ø> (ø)
packages/migrations-mongodb/src/Migrator.ts 97.77% <100.00%> (+0.02%) ⬆️
packages/migrations/src/Migrator.ts 97.90% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/migrations-mongodb/src/Migrator.ts Outdated Show resolved Hide resolved
packages/migrations-mongodb/src/Migrator.ts Outdated Show resolved Hide resolved
packages/migrations/src/Migrator.ts Outdated Show resolved Hide resolved
packages/migrations-mongodb/src/Migrator.ts Outdated Show resolved Hide resolved
@AnimeshRy
Copy link
Contributor Author

AnimeshRy commented Mar 30, 2023

@B4nan Can we also enforce indent with eslint aswell ? I can't find the indent setting present in the current config file ?

@B4nan B4nan changed the title refactor(core): option to make migrator 'silent' feat(migrator): allow disabling logging via migrations.silent Mar 30, 2023
@B4nan B4nan merged commit 4b778bf into mikro-orm:master Mar 30, 2023
@B4nan
Copy link
Member

B4nan commented Mar 30, 2023

Thanks!

Feel free to send a separate PR improving the eslint config 👍

jsprw pushed a commit to jsprw/mikro-orm-full-text-operators that referenced this pull request May 7, 2023
…o-orm#4182)

This provides an option to make the migration logs silent.

Closes mikro-orm#4124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to make migrator 'quiet'
2 participants