fix: ensure correct application shutdown with forRootAsync and multiple databases #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on shutdown it fails to find MikroORM and causes a shutdown error.
|
Thanks! The changes in lock file look weird, can you remove those please? |
Sure can do! I just did a |
|
hold on the PR for a sec found a bug |
|
Weird that an install would alter lock file. I will rebuild it when releasing and update deps if needed. |
It could of been done with me trying to get sqlite working on this machine which stopped me from running the tests. I have also resolved the bug 👍 |
|
Last time I had sqlite build issues installing node gyp as a dev dep explicitly helped. I can add that too, but I dont want to mix it with other changes in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
forRootAsyncmodule with multiple databases on application shutdown it fails to find MikroORM and causes a shutdown error.NOTE: I tried to make a test for this in mikro-orm.middleware.test.ts but it seems the
AfterAlllifecycle is swallowing the error and unsure if its a configuration issue as on other projects I've seenAfterAllfail on errors