Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency aquaproj/aqua to v2.7.0 #104

Merged
merged 1 commit into from
May 17, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
aquaproj/aqua minor v2.4.3 -> v2.7.0

Release Notes

aquaproj/aqua

v2.7.0

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.6.0...v2.7.0

Features

#​1803 #​2002 Support unarchiving PKG format on macOS

Others

#​1996 Update slsa-verifier to v2.3.0
#​1997 #​2001 Refactoring

v2.6.0

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.5.2...v2.6.0

Features

#​1984 generate-registry: Enable to parse tags not conforming to semver

If you don't develop Registry or don't contribute to Standard Registry, you can ignore this release.

generate-registry command couldn't parse tags not conforming to semver.
This release enables aqua to parse those tags and extract prefixes and versions.

For example, this release enables aqua to parse the tag version_112 and extracts the prefix version_ and the version 112.

v2.5.2

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.5.1...v2.5.2

Fixes

#​1983 generate-registry: Use the default checksum parser

v2.5.1

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.5.0...v2.5.1

Fixes

#​1979 generate-registry: Add unknown-linux and pc-windows to patterns of replacements
#​1872 #​1976 Move the symbolic link of aqua-proxy from $AQUA_ROOT_DIR/bin/aqua-proxy to $AQUA_ROOT_DIR/aqua-proxy

v2.5.0

Compare Source

Pull Requests | Issues | aquaproj/aqua@v2.4.3...v2.5.0

Features

#​1925 #​1926 Execute commands by execve(2) by default

https://aquaproj.github.io/docs/reference/execve-2

#​710 #​729 #​1597 #​1925

⚠️ In Windows this feature doesn't work.
In Windows, aqua creates small shell scripts and bat scripts instead of aqua-proxy and symbolic links.
And Windows doesn't support execve(2), so the environment variable AQUA_X_SYS_EXEC is ignored.

When a command x is executed via aqua, the command is executed as the following.

  1. $AQUA_ROOT_DIR/bin/x: symbolic link to aqua-proxy
  2. aqua-proxy executes the command aqua exec -- x
  3. aqua executes x

So the command x is executed via aqua-proxy and aqua.
Until aqua v2.5.0, aqua-proxy and aqua executed commands as subprocess. You can confirm it by checking the process tree by pstree command.

e.g.

$ nvim # nvim is managed by aqua
$ pstree -s nvim
     \-+= 00719 shunsukesuzuki -zsh
       \-+= 09955 shunsukesuzuki nvim # aqua-proxy
         \-+- 09956 shunsukesuzuki aqua exec -- nvim
           \--- 09957 shunsukesuzuki /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/neovim/neovim/v0.7.0/nvim-macos.tar.gz/nvim-osx64/bin/nvim
aqua-proxy -> aqua -> x

Sometimes this behaviour caused trouble. #​710 #​1597

From aqua v2.5.0, aqua-proxy and aqua execute commands by execve(2) in Linux and macOS by default.

So extra subprocess isn't raised.

     \-+= 82315 shunsukesuzuki -zsh
       \-+= 82630 shunsukesuzuki nvim

If you feel aqua becomes unstable due to this feature, you can disable this feature by the environment variable AQUA_X_SYS_EXEC.

export AQUA_X_SYS_EXEC=false
Others

#​1926 Update aqua-proxy to v1.2.0
#​1964 Improve error messages when it failed to install aqua-proxy, cosign, and slsa-verifier


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@mikutas
Copy link
Owner

mikutas commented May 7, 2023

詳細不明だがaquaの2.5.0に起因してtestが失敗していると思われる
aqua経由でインストールしたlinkerdを(aquaバージョンが2.5.0の状態で)使うとlinkerd checkの途中でエラーが起きる
~/.local/share以下のコマンドを直接起動するとlinkerd checkは成功する
(=~/.local/share/aquaproj-aqua/pkgs/github_release/github.com/linkerd/linkerd2/stable-2.13.2/linkerd2-cli-stable-2.13. 2-linux-amd64/linkerd2-cli-stable-2.13.2-linux-amd64 checkする)
2.5.0でaqua iした後でも2.4.3に戻すとlinkerd check成功する

@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from af55c8e to 85a40f9 Compare May 7, 2023 15:27
@mikutas
Copy link
Owner

mikutas commented May 8, 2023

image

これ?

つまりこれ https://github.com/aquaproj/aqua-proxy/releases/tag/v1.2.0

@mikutas
Copy link
Owner

mikutas commented May 8, 2023

コマンドの途中で失敗して不思議なのはlinkerd checkの実行中にさらにlinkerd viz checkを呼び出していて、それが失敗している

@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from 11b502f to 335b26d Compare May 11, 2023 01:26
@renovate renovate bot changed the title chore(deps): update dependency aquaproj/aqua to v2.5.0 chore(deps): update dependency aquaproj/aqua to v2.6.0 May 11, 2023
@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from 335b26d to e32597e Compare May 11, 2023 01:30
@mikutas
Copy link
Owner

mikutas commented May 11, 2023

AQUA_X_SYS_EXEC | aqua

@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from e32597e to 44a5704 Compare May 12, 2023 03:10
@mikutas
Copy link
Owner

mikutas commented May 12, 2023

@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch 2 times, most recently from 18df6c2 to 4b5dc35 Compare May 17, 2023 00:19
@renovate renovate bot changed the title chore(deps): update dependency aquaproj/aqua to v2.6.0 chore(deps): update dependency aquaproj/aqua to v2.7.0 May 17, 2023
@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from 4b5dc35 to 4843851 Compare May 17, 2023 03:32
@renovate renovate bot force-pushed the renovate/aquaproj-aqua-2.x branch from 4843851 to 51336f1 Compare May 17, 2023 03:36
@mikutas mikutas merged commit 307d394 into main May 17, 2023
@mikutas mikutas deleted the renovate/aquaproj-aqua-2.x branch May 17, 2023 03:43
@suzuki-shunsuke
Copy link

@mikutas たまたまこの pull request 見つけたので discussion 作成しました。
時間のあるときに見てみます。
https://github.com/orgs/aquaproj/discussions/2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants