perplexity aggregation scheme #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocks/monitoring/aggregation.py
Outdated
| variable = tensor.exp(-log_likelihood / n_examples) | ||
| variable.tag.aggregation_scheme = Perplexity(log_likelihood, n_examples) | ||
| # There is no good default name for the output variable, | ||
| # so we don't try set any. |
There was a problem hiding this comment.
Why not name it 'perplexity'?
There was a problem hiding this comment.
At first I thought and it would be not nice to return always the same name. But maybe it's an okay default. Will change.
|
Your only comment was addressed, can you please look again? |
|
Ok, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two nice things: (a) improves the test of the
Meanaggregation scheme to check what actually happens when batch sizes are different (b) adds and tests aPerplexityscheme, which in fact was the original motivation for the aggregation schemes 2 years ago..@dmitriy-serdyuk , can you please review this?