Filter by unbound application and call_id

[rizar]

This PR does two things:

1. It makes it possible to filter by an unbound application, e.g. Linear.apply
2. It introduces an optional keyword argument call_id that writes a call identifier to the metadata attribute of the ApplicationCall object. VariableFilter is modified to support filtering by this new attribute. The usecase that I have in mind is when an application method is called twice, e.g. an RNN is used to encode both the question the answer. It is useful in such cases to make a distinction between the variables created in the first and in the second call.

[dmitriy-serdyuk]

I have a question about 2. Does the call id propagate recursively to applications inside the top level application? Do you plan to annotate every brick with the call id?

It seems that this feature needs to be documented. Maybe in some future PR.

[rizar]

Does the call id propagate recursively to applications inside the top level application?

Nope.

Do you plan to annotate every brick with the call id?

Nope, call id can be passed like brick.apply(x,y,z, call_id='123') and it will be assigned to application call not to a brick. As for documenting it, it is not very clear where it should be documented: as_dict and as_list, which are implemented in a very similar way, aren't documented.

[rizar]

So, what's your opinion, @dmitriy-serdyuk ?

[dmitriy-serdyuk]

It looks good. But I don't understand why the test fails.

[rizar]

It does not seem though that failing test are due to this PR. That said, I will go ahead and merge it.

…

On Thu, 13 Jul 2017 at 11:00 Dmitriy Serdyuk ***@***.***> wrote: It looks good. But I don't understand why the test fails. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1194 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAn8Yttor38znY-RNmzx2aEuAMcHX1ACks5sNjEmgaJpZM4ORaXQ> .