Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docstring for tied_biases #803

Merged
merged 3 commits into from
Aug 15, 2015
Merged

Conversation

tejaskhot
Copy link
Contributor

Solved issue #722

Added missing documentation for tied_biases in the Convolutional class docstring
@tejaskhot
Copy link
Contributor Author

@dwf @rizar I am a new contributor to blocks and this is my first PR. I verified wth flake8 and pep8 and it passed those tests offline. I cannot understand the Scrutinizer's D504: Docstring exceeds 75 characters error since the docstring for num_channels is actually longer than the one I added for tied_biases

Could you please help me understand how I can check for Scrutinizer and travis issues ? This is new to me so some help at the start will be very much helpful.

@dwf
Copy link
Contributor

dwf commented Aug 15, 2015

It's the actual line length it's complaining about, not the length of the section. The docstring standard we follow specifies 75 characters per line maximum in docstrings. So you'll need to rewrap.

@dwf
Copy link
Contributor

dwf commented Aug 15, 2015

Don't worry about the Travis failure, that looks unrelated (@rizar?).

@tejaskhot
Copy link
Contributor Author

@dwf It seems solved...can be merged now

@dwf
Copy link
Contributor

dwf commented Aug 15, 2015

LGTM, thanks.

dwf added a commit that referenced this pull request Aug 15, 2015
@dwf dwf merged commit 9c2a1a1 into mila-iqia:master Aug 15, 2015
@tejaskhot tejaskhot deleted the Tejas-Khot-patch-1 branch August 15, 2015 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants