-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float64sr via Double64 #61
Conversation
Sure, I will try it out. ◡̎ |
A single error is occurring, unrelated to this pull request Test Summary: | Pass Fail Total Time
Test for U(0,1) | 29999 1 30000 15.4s which seems to be because a Float16sr isn't rounded to either of two but of three (for whatever buggy reason) numbers Test for U(0,1): Test Failed at /home/runner/work/StochasticRounding.jl/StochasticRounding.jl/test/float16sr.jl:114
Expression: Ndown + Nup == N
Evaluated: 99999 == 100000 |
This ☝🏼 error is now issued in #62, so @avleenk2312 please ignore it here. Have you had a chance to test Float64sr? |
Thanks for pointing out this error. We just completed our code that uses Float32sr tonight. I have started looking into Float64sr now. I will get back to you. |
@avleenk2312 As #62 was resolved with #67 these tests here now pass. However, we're not actually testing Float64sr in |
Have added a small test set similar to other formats, locally tests pass. So the implementation looks good! |
Screw this, there's another one of those from #62 [ Info: Test failed for 5.5849552e-5, 0000001110101001
Test for subnormals: Test Failed at /home/runner/work/StochasticRounding.jl/StochasticRounding.jl/test/float16sr.jl:179
Expression: Ndown + Nup == N
Evaluated: 99990 == 100000
[ Info: Test failed for -5.5849552e-5, 1000001110101001
Test Summary: | Pass Fail Total Time
Test for subnormals | 59998 2 60000 25.1s
ERROR: LoadError: Some tests did not pass: 59998 passed, 2 failed, 0 errored, 0 broken.
in expression starting at /home/runner/work/StochasticRounding.jl/StochasticRounding.jl/test/float16sr.jl:162 |
fixes #59
@avleenk2312 could you try out this branch (and maybe even write some tests for it? 😄) before I merge it?