changed random string in prod to start with a letter #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-robertson
commented
Mar 20, 2018
| @@ -66,7 +66,7 @@ export default function style( | |||
| // Aesthetic's caching layer. | |||
| } else { | |||
| instanceID += 1; | |||
| styleName = `${Math.random().toString(32).substr(2)}${instanceID}`; | |||
| styleName = `c${Math.random().toString(32).substr(2)}${instanceID}`; | |||
There was a problem hiding this comment.
CSS cant start with a number, so added a 'c' to the start of this string
|
Awesome thank you! |
|
Whats the deal with releasing/tagging new version with this ? a project im working on cant be upgraded till this is released and id like to upgrade it if possible |
|
I'm at work but I can tag a new version later tonight. |
|
Thank you, appreciate it! |
|
@DesignAlchemy Releases tagged. |
|
Thank you 👍
Took ages to figure out what was going on haha |
|
Awesome! I'm surprised it hasn't come up earlier :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.