Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics to prometheus #39

Open
paulfantom opened this issue Jun 4, 2020 · 1 comment
Open

Expose metrics to prometheus #39

paulfantom opened this issue Jun 4, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@paulfantom
Copy link

I believe it would be beneficial to instrument shynet with prometheus metrics as well as expose data collected by shynet in prometheus format. This would provide two benefits:

  • with an instrumented application, a monitoring system can act on issues with shynet itself
  • exposing data collected by shynet would allow to correlate it with other data in prometheus and create meaningful alerts about website.

I propose prometheus exposition format as there is already an official python library and format is on the path to becoming an RFC standard (under the name of OpenMetrics).

@milesmcc milesmcc self-assigned this Jun 4, 2020
@milesmcc milesmcc added the enhancement New feature or request label Jun 4, 2020
@milesmcc
Copy link
Owner

milesmcc commented Jun 5, 2020

Standardizing some kind of remote integration/export format (if I'm understanding this correctly) would be a great addition. Adding it to the roadmap for v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants