Added "Delete screenshot" option && solved bug after deleting #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mileswd
pushed a commit
that referenced
this pull request
Aug 27, 2014
Added "Delete screenshot" option && solved bug after deleting
mileswd
pushed a commit
that referenced
this pull request
Nov 30, 2014
Added "Delete screenshot" option && solved bug after deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've managed to solve it correctly
As the ScreenshotMonitor doesn't receive an event which can indicate if there has been an addition or a removal, I implemented a method "isDeletion(), which compares the blacklist length with the query results length.
When I tried to access the new query results after a deletion, it crashed, so I don't remove the deleted screenshot from the blacklist, but as its name is created based on the current time, it won't be added again