Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--redirect-delay replaced by --javascript-delay in wkhtmltopdf 10 #59

Closed
cfrankct opened this issue Nov 4, 2011 · 1 comment
Closed

Comments

@cfrankct
Copy link

cfrankct commented Nov 4, 2011

Looks like recent versions of wkhtmltopdf don't include --redirect-delay any longer. Seems it has been replaced by --javascript-delay with slightly different semantics. I couldn't find a change-log entry on the wkhtmltopdf site, but the readme says:

--javascript-delay <msec> Wait some milliseconds for javascript finish (default 200) and makes no mention of the redirect-delay any longer. Fix is trivial, line 143 in wicked_pdf.rb becomes:

r +=make_options(options, [ :javascript_delay,

@unixmonkey
Copy link
Collaborator

Both are now supported, as of this commit:

3ef2253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants