Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running make deletes committed test file #60

Closed
jfkw opened this issue Jun 30, 2015 · 2 comments
Closed

Running make deletes committed test file #60

jfkw opened this issue Jun 30, 2015 · 2 comments

Comments

@jfkw
Copy link

jfkw commented Jun 30, 2015

Running make will delete a committed file tests/notebook/Islands Tests.ipynb. Would it be possible to replace this file at the end of the test, or test deletion using a copy? The benefit would be keeping a clean git checkout.

% make
(...)
% git status
 D "tests/notebook/Islands Tests.ipynb"
?? tests/notebook/Untitled0.ipynb
?? tests/notebook/Untitled1.ipynb
?? tests/notebook/Untitled2.ipynb
?? tests/notebook/Untitled3.ipynb
?? tests/notebook/Untitled4.ipynb
?? tests/notebook/Untitled5.ipynb
?? tests/notebook/Untitled6.ipynb
@millejoh
Copy link
Owner

millejoh commented Jul 2, 2015

That test file isn't used for anything, so I have deleted it. Almost all of my development work is on Windows, so I rarely use make. I tried committing a small change to delete the ipynb files when calling make clean. Let me know if that is the behavior you are hoping for.

@jfkw
Copy link
Author

jfkw commented Jul 2, 2015

Fixed with 10044dd

@jfkw jfkw closed this as completed Jul 2, 2015
dickmao added a commit that referenced this issue Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants