Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for VS 2015: it doesn`t support stdint.h #676

Closed
wants to merge 1 commit into from

Conversation

aalex
Copy link

@aalex aalex commented Jul 6, 2016

Visual Studio 2015 doesn't support stdint.h yet, so we should include msinttypes/stdint.h instead of stdint.h

Visual Studio 2015 doesn't support stdint.h yet, so we should include msinttypes/stdint.h instead of stdint.h
@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling a05b922 on aalex:fix-vs2015-stdint-include into 5e8a382 on miloyip:master.

@pah
Copy link
Contributor

pah commented Jul 6, 2016

Why is this needed in your environment? What error do you see otherwise?

The Appveyor build is successful on MSVC 2015 for the current master, without using the local stdint.h implementation.

@aalex
Copy link
Author

aalex commented Jul 6, 2016

It seems like I can't reproduce the error right now.
It's documented here: http://stackoverflow.com/questions/126279/c99-stdint-h-header-and-ms-visual-studio

@pah
Copy link
Contributor

pah commented Jul 6, 2016

The stackoverflow question is pretty old (2008). In the answers, it's also documented, that Visual Studio supports <stdint.h> (to some extent) since 2010.

@miloyip
Copy link
Collaborator

miloyip commented Jul 8, 2016

Appveyor shows that RapidJSON can be successfully built under VC2010 to VC2015.
So I close this now.

@miloyip miloyip closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants