Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL doesn't seem to work #41

Closed
teleharry opened this issue Apr 16, 2023 · 2 comments
Closed

SSL doesn't seem to work #41

teleharry opened this issue Apr 16, 2023 · 2 comments

Comments

@teleharry
Copy link

The options seems to be missing in const server = ldap.createServer();
So, ldaps doesn't work, even ldapCertFilename and ldapKeyFilename ist defined.

Could you change it for future release?

if (config.ldapCertFilename && config.ldapKeyFilename) {
  const ldapCert = fs.readFileSync(new URL(`./${config.ldapCertFilename}`, import.meta.url), { encoding: "utf8" }),
      ldapKey = fs.readFileSync(new URL(`./${config.ldapKeyFilename}`, import.meta.url), { encoding: "utf8" });
  options = { certificate: ldapCert, key: ldapKey };
}
const server = ldap.createServer(options);
@milux
Copy link
Owner

milux commented Apr 20, 2023

If you already have fixed that, could you provide us a PR please? :)

@milux
Copy link
Owner

milux commented Aug 15, 2023

Fixed in version 3.1.0.

@milux milux closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants