Skip to content

Commit

Permalink
* remove annoy search parameter validation (#2667)
Browse files Browse the repository at this point in the history
Signed-off-by: cmli <chengming.li@zilliz.com>

* fix test failed

Signed-off-by: cmli <chengming.li@zilliz.com>

* fix lint error

Signed-off-by: cmli <chengming.li@zilliz.com>

* fix lint error again

Signed-off-by: cmli <chengming.li@zilliz.com>

Co-authored-by: cmli <chengming.li@zilliz.com>
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>

Co-authored-by: op-hunter <ophunter52@gmail.com>
Co-authored-by: cmli <chengming.li@zilliz.com>
  • Loading branch information
3 people committed Jun 24, 2020
1 parent 99fe8d9 commit 403753a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Please mark all changes in change log and use the issue from GitHub
- \#2598 fix Milvus docker image report illegal instruction
- \#2617 Fix HNSW and RNSG index files size
- \#2637 Suit the range of HNSW parameters
- \#2649 search parameter of annoy has conflict with document

## Feature
- \#2319 Redo metadata to support MVCC
Expand Down
4 changes: 2 additions & 2 deletions core/src/server/ValidationUtil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,8 @@ ValidateSearchParams(const milvus::json& search_params, const engine::meta::Coll
break;
}
case (int32_t)engine::EngineType::ANNOY: {
auto status = CheckParameterRange(search_params, knowhere::IndexParams::search_k, topk,
std::numeric_limits<int64_t>::max());
auto status = CheckParameterRange(search_params, knowhere::IndexParams::search_k,
std::numeric_limits<int64_t>::min(), std::numeric_limits<int64_t>::max());
if (!status.ok()) {
return status;
}
Expand Down

0 comments on commit 403753a

Please sign in to comment.