#2649 Remove annoy search parameter validation #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cmli <chengming.li@zilliz.com> * fix test failed Signed-off-by: cmli <chengming.li@zilliz.com> * fix lint error Signed-off-by: cmli <chengming.li@zilliz.com> * fix lint error again Signed-off-by: cmli <chengming.li@zilliz.com> Co-authored-by: cmli <chengming.li@zilliz.com> Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
Codecov Report
@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
- Coverage 86.92% 86.91% -0.01%
==========================================
Files 423 423
Lines 27494 27494
==========================================
- Hits 23898 23897 -1
- Misses 3596 3597 +1
|
wxyucs
approved these changes
Jun 24, 2020
tinkerlin
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cmli chengming.li@zilliz.com
What type of PR is this?
bug
Need this PR be picked to master branch?
No
Which issue(s) this PR fixes:
Fixes #2649
What this PR does / why we need it:
search parameter of annoy has conflict with document
Special notes for your reviewer:
no
Additional documentation (e.g. design docs, usage docs, etc.):
none