Fix program crash caused by incorrect use of noexcept modifier (#25194)…

… (#25214) Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
milvus-io · Jun 30, 2023 · 7f3f18e · 7f3f18e
1 parent f7ecbff
commit 7f3f18e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/core/src/storage/MemFileManagerImpl.cpp b/internal/core/src/storage/MemFileManagerImpl.cpp
@@ -34,7 +34,7 @@ MemFileManagerImpl::AddFile(const std::string& filename /* unused */) noexcept {
 }
 
 bool
-MemFileManagerImpl::AddFile(const BinarySet& binary_set) noexcept {
+MemFileManagerImpl::AddFile(const BinarySet& binary_set) {
     std::vector<const uint8_t*> data_slices;
     std::vector<int64_t> slice_sizes;
     std::vector<std::string> slice_names;

diff --git a/internal/core/src/storage/MemFileManagerImpl.h b/internal/core/src/storage/MemFileManagerImpl.h
@@ -58,7 +58,7 @@ class MemFileManagerImpl : public FileManagerImpl {
     CacheRawDataToMemory(std::vector<std::string> remote_files);
 
     bool
-    AddFile(const BinarySet& binary_set) noexcept;
+    AddFile(const BinarySet& binary_set);
 
     std::map<std::string, int64_t>
     GetRemotePathsToFileSize() const {