Fix program crash caused by incorrect use of noexcept modifier #25194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
xiaocai2333
force-pushed
the
fix_panic_error
branch
from
5ade583
to
5e85c8e
Compare
xiaocai2333
requested review from
xige-16 and
xiaofan-luan
and removed request for
godchen0212
Codecov Report
@@ Coverage Diff @@
## 2.2.0 #25194 +/- ##
==========================================
+ Coverage 80.63% 80.66% +0.02%
==========================================
Files 761 761
Lines 107527 107527
==========================================
+ Hits 86704 86732 +28
+ Misses 17499 17474 -25
+ Partials 3324 3321 -3
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaocai2333, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
should be in 2.2.12 please also bring it into master |
xiaocai2333
added a commit
to xiaocai2333/milvus
that referenced
this pull request
Jun 28, 2023
…s-io#25194) Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jun 30, 2023
… (#25214) Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
zhuwenxing
pushed a commit
to mmga-lab/milvus
that referenced
this pull request
Jul 25, 2023
…s-io#25194) (milvus-io#25214) Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #25129