Skip to content

Commit

Permalink
fix: Check nodeID wildcard when removing pkOracle (#33895)
Browse files Browse the repository at this point in the history
See also #33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
  • Loading branch information
congqixia committed Jun 18, 2024
1 parent 8cdc0e6 commit ec64499
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion internal/querynodev2/pkoracle/candidate.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ func WithSegmentType(typ commonpb.SegmentState) CandidateFilter {
// WithWorkerID returns CandidateFilter with provided worker id.
func WithWorkerID(workerID int64) CandidateFilter {
return func(candidate candidateWithWorker) bool {
return candidate.workerID == workerID
return candidate.workerID == workerID ||
workerID == -1 // wildcard for offline node
}
}

Expand Down

0 comments on commit ec64499

Please sign in to comment.