Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: PK oracle cannot be removed when worker is offline #33894

Closed
1 task done
congqixia opened this issue Jun 17, 2024 · 0 comments
Closed
1 task done

[Bug]: PK oracle cannot be removed when worker is offline #33894

congqixia opened this issue Jun 17, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 188ee43
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When sync distribution api tries to remove distribution for offline worker, the worker is set to -1. In this case, WithWorkerID filter could never match pk oracle candidate

Expected Behavior

PK oracle candidate shall be remove successfully when worker is offline

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 17, 2024
@congqixia congqixia self-assigned this Jun 17, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jun 17, 2024
@congqixia
fix: Check nodeID wildcard when removing pkOracle
dafd8d8 
See also milvus-io#33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 17, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 18, 2024
@congqixia
fix: Check nodeID wildcard when removing pkOracle
59297f4 
See also milvus-io#33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 18, 2024
@congqixia
fix: Check nodeID wildcard when removing pkOracle (#33895)
ec64499 
See also #33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 20, 2024
@congqixia
fix: Check nodeID wildcard when removing pkOracle (milvus-io#33895)
e72897f 
See also milvus-io#33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 20, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 20, 2024
@congqixia
fix: Check nodeID wildcard when removing pkOracle (milvus-io#33895)
026b371 
See also milvus-io#33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jun 20, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 21, 2024
@congqixia
fix: [2.4] Check nodeID wildcard when removing pkOracle (#33895) (#34020
891a94a 
)

Cherry-pick from master
pr: #33895
See also #33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 21, 2024
@congqixia
fix: [2.3] Check nodeID wildcard when removing pkOracle (#33895) (#34022
ce7bcee 
)

Cherry-pick from master
pr: #33895
See also #33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@congqixia @yellow-shine
fix: Check nodeID wildcard when removing pkOracle (milvus-io#33895)
ee33a8f 
See also milvus-io#33894

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia