Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: DC will panic if set EnableCompaction set to false #31059

Closed
1 task done
XuanYang-cn opened this issue Mar 6, 2024 · 7 comments
Closed
1 task done

[Bug]: DC will panic if set EnableCompaction set to false #31059

XuanYang-cn opened this issue Mar 6, 2024 · 7 comments
Assignees
@XuanYang-cn
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@XuanYang-cn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

image

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@XuanYang-cn XuanYang-cn added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@XuanYang-cn XuanYang-cn added this to the 2.3.11 milestone Mar 6, 2024
@XuanYang-cn XuanYang-cn self-assigned this Mar 6, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 6, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
f53af67 
See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Mar 6, 2024
Closed
@XuanYang-cn XuanYang-cn modified the milestones: 2.3.11, 2.4.0 Mar 6, 2024
@XuanYang-cn
Copy link
Contributor Author

2.3 doesn't need it since there're no removeTaskByChannel in 2.3 branch

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 6, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
9d3e365 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 11, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
e650b9c 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 12, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
74ac674 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 13, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
971f1c5 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 14, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
f5f7ad8 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 14, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
e09caab 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 25, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
e9e78ac 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 26, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
897bb97 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 27, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
6261377 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn removed this from the 2.4.0 milestone Mar 27, 2024
@XuanYang-cn
Copy link
Contributor Author

Doesn't influence 2.4.0

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 28, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
3571ce4 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Mar 28, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
b414e35 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 1, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
84b6781 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 7, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
ab42fbd 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 8, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
6c6c0d4 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 9, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
02e3513 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 9, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
21b43e9 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 10, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
b92fb59 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 17, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
54125cc 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 18, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
ee49e36 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 23, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
063a345 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 23, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
ae05d91 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 23, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
14df1d2 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 24, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
4e90a86 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Apr 26, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
491987b 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@stale Stale
Copy link

stale bot commented May 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 1, 2024
@XuanYang-cn XuanYang-cn mentioned this issue May 8, 2024
Closed
1 task
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue May 8, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
6f4610b 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue May 11, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
99bb5ad 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@stale stale bot closed this as completed May 12, 2024
@XuanYang-cn XuanYang-cn reopened this May 13, 2024
@stale stale bot removed the stale indicates no udpates for 30 days label May 13, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue May 13, 2024
@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
6a8b0cb 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@stale Stale
Copy link

stale bot commented Jun 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 13, 2024
@XuanYang-cn
Copy link
Contributor Author

keep it

@stale stale bot removed the stale indicates no udpates for 30 days label Jun 24, 2024
@XuanYang-cn
Copy link
Contributor Author

Too many changes on compaction lately, will focus on fixing the panic in next pr

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 24, 2024
@XuanYang-cn
fix: Milvus panic when compaction disabled and dropping a collection
811f407 
See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 24, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 26, 2024
@XuanYang-cn
fix: Milvus panic when compaction disabled and dropping a collection
2e9ab6d 
See also: milvus-io#31059
pr: milvus-io#34103

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 26, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 27, 2024
@XuanYang-cn
fix: Milvus panic when compaction disabled and dropping a collection
26e3823 
See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 11, 2024
@XuanYang-cn
fix: Milvus panic when compaction disabled and dropping a collection (#…
7e2a9d6 
…34206)

See also: #31059
pr: #34103

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 11, 2024
@XuanYang-cn
fix: Milvus panic when compaction disabled and dropping a collection (#…
e0b39d8 
…34103)

See also: #31059

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuanYang-cn XuanYang-cn

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XuanYang-cn @yanliang567