Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: enable compaction dynamicly #31068

Closed
wants to merge 6 commits into from
Closed

enhance: enable compaction dynamicly #31068

wants to merge 6 commits into from

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Mar 6, 2024 •
edited
Loading

Make EnableCompaction able to change dynamicly

See also: #31059

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 6, 2024
congqixia
congqixia reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's a better solution to have compaction tigger&handler intialized even when compaction is disabled
also we could change EnableCompaction to runtime changeable param item

@congqixia congqixia changed the title fix: DC painc at dropvchannel when disable compaction fix: DC panicking at dropvchannel when disable compaction Mar 6, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Mar 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.58140% with 31 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (3d29907) to head (071082c).
Report is 232 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31068      +/-   ##
==========================================
- Coverage   82.21%   82.20%   -0.01%     
==========================================
  Files        1012     1003       -9     
  Lines      129202   129446     +244     
==========================================
+ Hits       106223   106413     +190     
- Misses      19001    19055      +54     
  Partials     3978     3978
Files Coverage Δ
internal/datacoord/compaction_trigger_v2.go 90.24% <100.00%> (ø)
internal/datacoord/compaction_view_manager.go 97.01% <100.00%> (ø)
internal/datacoord/index_service.go 94.88% <ø> (-0.01%) ⬇️
internal/datacoord/meta.go 93.45% <100.00%> (-0.84%) ⬇️
internal/datacoord/server.go 72.03% <100.00%> (+0.02%) ⬆️
pkg/util/paramtable/component_param.go 98.50% <ø> (ø)
internal/datacoord/services.go 85.93% <25.00%> (+0.21%) ⬆️
internal/datacoord/compaction.go 89.90% <82.05%> (+1.28%) ⬆️
internal/datacoord/compaction_trigger.go 87.68% <84.78%> (+0.22%) ⬆️

... and 219 files with indirect coverage changes

@XuanYang-cn
Copy link
Contributor Author

install failed
/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Mar 11, 2024
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Mar 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

install failed
/run-cpu-e2e

@XuanYang-cn XuanYang-cn force-pushed the fix-panic-31059 branch 2 times, most recently from f5f7ad8 to e09caab Compare March 14, 2024 06:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 25, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn XuanYang-cn requested a review from tedxu April 28, 2024 07:38
@tedxu
Copy link
Collaborator

tedxu commented Apr 28, 2024

/lgtm

@XuanYang-cn XuanYang-cn mentioned this pull request May 8, 2024
Closed
1 task
@sre-ci-robot sre-ci-robot removed the lgtm label May 8, 2024
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mergify mergify bot removed the ci-passed label May 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 11, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 11, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
fix: DC painc at dropvchannel when disable compaction
6a8b0cb 
Make EnableCompaction able to change dynamicly

See also: milvus-io#31059

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
fix conflict
438aa5d 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label May 13, 2024
@XuanYang-cn
Merge remote-tracking branch 'upstream/master' into fix-panic-31059
8888a21
@XuanYang-cn
fix conflict
3bc39e0 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
fix coding style
ca53e1c 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels May 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added ci-passed and removed ci-passed labels May 28, 2024
@stale Stale
Copy link

stale bot commented Jun 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 27, 2024
@stale stale bot closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@congqixia congqixia Awaiting requested review from congqixia

@tedxu tedxu Awaiting requested review from tedxu

Assignees

@tedxu tedxu

Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines. stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XuanYang-cn @tedxu @sre-ci-robot @congqixia