Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: DataNode Compactor tracing and timing is confusing #32451

Closed
1 task done
XuanYang-cn opened this issue Apr 19, 2024 · 1 comment
Closed
1 task done

[Enhancement]: DataNode Compactor tracing and timing is confusing #32451

XuanYang-cn opened this issue Apr 19, 2024 · 1 comment
Assignees
@XuanYang-cn
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@XuanYang-cn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

image

Why is this needed?

No response

Anything else?

No response
@XuanYang-cn XuanYang-cn added the kind/enhancement Issues or changes related to enhancement label Apr 19, 2024
@XuanYang-cn XuanYang-cn self-assigned this Apr 19, 2024
@XuanYang-cn XuanYang-cn mentioned this issue Apr 19, 2024
Merged
@stale Stale
Copy link

stale bot commented May 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 19, 2024
sre-ci-robot pushed a commit that referenced this issue May 23, 2024
@XuanYang-cn
enhance: Tidy compactor and remove dup codes (#32198)
22bddde 
See also: #32451

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@stale stale bot closed this as completed Jun 5, 2024
@bigsheeper bigsheeper mentioned this issue Jun 12, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 14, 2024
@bigsheeper
enhance: Tidy compaction executor (#33778)
86a36b1 
Move compaction executor to compaction pacakge.

issue: #32451

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 24, 2024
@XuanYang-cn
enhance: [cherry-pick] Move compactor into sub package
d5c2dbb 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (milvus-io#32198)
- fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
- enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
- enhance: enable stream writer in compactions (milvus-io#32612)

See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679
pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 24, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 25, 2024
@XuanYang-cn @tedxu
enhance: [cherry-pick] Move compactor into sub package (#34098)
a33b686 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (#32198)
- fix: Fix l0 compactor may cause DN from OOM (#33554)
- enhance: Add deltaRowCount in l0 compaction (#33997)
- enhance: enable stream writer in compactions (#32612)
- fix: turn on compression on stream writers (#34067)
- fix: adding blob memory size in binlog serde (#33324)

See also: #32451, #33547, #33998, #31679
pr: #32198, #33554, #33997, #32612

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
@bigsheeper bigsheeper mentioned this issue Jul 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 2, 2024
@bigsheeper @forsaken628
enhance: [cherry-pick] Batch pick PRs related to compaction (#34315)
1b95ee7 
This PR cherry-picks the following commits related to compaction:

- Use a pool for CompactionExecutor.
#33558
- Move compaction executor to compaction pacakge.
#33778
- Ensure the idempotency of compaction tasks.
#33872
- Add comment for channel cp updater.
#33759

issue: #33182,
#32451

pr: #33558,
#33778,
#33872,
#33759

---------

Signed-off-by: coldWater <254244460@qq.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Co-authored-by: coldWater <254244460@qq.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@bigsheeper @yellow-shine
enhance: Tidy compaction executor (milvus-io#33778)
b21e63c 
Move compaction executor to compaction pacakge.

issue: milvus-io#32451

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuanYang-cn XuanYang-cn

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XuanYang-cn