Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: use deleleRowCount for each L0 compaction view #33998

Closed
1 task done
XuanYang-cn opened this issue Jun 19, 2024 · 0 comments
Closed
1 task done

[Enhancement]: use deleleRowCount for each L0 compaction view #33998

XuanYang-cn opened this issue Jun 19, 2024 · 0 comments
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@XuanYang-cn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

deleteRowCount can be used to calculate the costs of L0 compaction

Why is this needed?

No response

Anything else?

No response
@XuanYang-cn XuanYang-cn added the kind/enhancement Issues or changes related to enhancement label Jun 19, 2024
This was referenced Jun 19, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 20, 2024
@XuanYang-cn
enhance: Add deltaRowCount in l0 compaction (#33997)
04edb07 
See also: #33998

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jun 20, 2024
@XuanYang-cn
enhance: Add deltaRowCount in l0 compaction (#33843)
e55fee6 
See also: #33998 
pr: #33997

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this issue Jun 24, 2024
@XuanYang-cn
enhance: [cherry-pick] Move compactor into sub package
d5c2dbb 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (milvus-io#32198)
- fix: Fix l0 compactor may cause DN from OOM (milvus-io#33554)
- enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
- enhance: enable stream writer in compactions (milvus-io#32612)

See also: milvus-io#32451, milvus-io#33547, milvus-io#33998, milvus-io#31679
pr: milvus-io#32198, milvus-io#33554, milvus-io#33997, milvus-io#32612

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this issue Jun 24, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 25, 2024
@XuanYang-cn @tedxu
enhance: [cherry-pick] Move compactor into sub package (#34098)
a33b686 
This PR consists of the following commits:

- enhance: Tidy compactor and remove dup codes (#32198)
- fix: Fix l0 compactor may cause DN from OOM (#33554)
- enhance: Add deltaRowCount in l0 compaction (#33997)
- enhance: enable stream writer in compactions (#32612)
- fix: turn on compression on stream writers (#34067)
- fix: adding blob memory size in binlog serde (#33324)

See also: #32451, #33547, #33998, #31679
pr: #32198, #33554, #33997, #32612

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this issue Jul 2, 2024
@XuanYang-cn @yellow-shine
enhance: Add deltaRowCount in l0 compaction (milvus-io#33997)
4ed8b59 
See also: milvus-io#33998

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XuanYang-cn