Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: optimize reduce perf #32507

Closed
1 task done
MrPresent-Han opened this issue Apr 22, 2024 · 4 comments
Closed
1 task done

[Enhancement]: optimize reduce perf #32507

MrPresent-Han opened this issue Apr 22, 2024 · 4 comments
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@MrPresent-Han
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

optimize the perf of stream reduce

Why is this needed?

  1. existing implementation involves too many comparisons which can be replaced with min-heap rather than max-heap
  2. existing search procedure drives search operations towards segments one by one, which may incur N times IO stress in the worst case, this can be optimized by group searched segments

Anything else?

No response

@MrPresent-Han MrPresent-Han added the kind/enhancement Issues or changes related to enhancement label Apr 22, 2024
@MrPresent-Han
Copy link
Contributor Author

/assign MrPresent-Han

Copy link

stale bot commented May 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 23, 2024
@MrPresent-Han MrPresent-Han changed the title [Enhancement]: optimize stream-reduce perf [Enhancement]: optimize reduce perf Jun 3, 2024
@stale stale bot removed the stale indicates no udpates for 30 days label Jun 3, 2024
@MrPresent-Han
Copy link
Contributor Author

In the process of reduce, we need to filter out some results with INVALID_TAG, this is due to the fact than knowhere will complement query results that are insufficient for topk. This problem waste some memory and cpu cycles in the process of reduce

Copy link

stale bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 7, 2024
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 11, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 11, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 11, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 12, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@stale stale bot closed this as completed Jul 16, 2024
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 18, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 18, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 19, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 22, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
MrPresent-Han pushed a commit to MrPresent-Han/milvus that referenced this issue Jul 22, 2024
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
sre-ci-robot pushed a commit that referenced this issue Jul 22, 2024
related: #32507

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

1 participant