Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: fix/re-enable unit test GetVectorFromChunkCache #33210

Closed
1 task done
zhengbuqian opened this issue May 21, 2024 · 3 comments
Closed
1 task done

[Enhancement]: fix/re-enable unit test GetVectorFromChunkCache #33210

zhengbuqian opened this issue May 21, 2024 · 3 comments
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@zhengbuqian
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

unit test GetVectorFromChunkCache in test_sealed.cpp was skipped due to a potential mem leak in AWS::InitSDK. I tried to re-enable it wondering if the AWS leak has been fixed, but this test failed due to failing connect to object store. this issue needs to be fixed.

Once the object store issue is fixed, we need to re-assess if the AWS mem leak still exist. Currently the entire gtest is suffering from mem leak, see #33139, but ASAN is turned off in CI, so we can enable the tests.

So TODOs are:

  1. fix the object store connection issue in fix: enable GetVectorFromChunkCache and WarmupChunkCache test #33115
  2. un-skip GetVectorFromChunkCache(and several other skipped tests)
  3. fix gtest mem leak in [Bug]: unit test may have mem leak caused by gtest framework #33139
  4. verify if the AWS leak has been fixed, if not, skip GetVectorFromChunkCache again
  5. enable ASAN in CI

Why is this needed?

No response

Anything else?

No response

@zhengbuqian zhengbuqian added the kind/enhancement Issues or changes related to enhancement label May 21, 2024
@zhengbuqian
Copy link
Collaborator Author

@bigsheeper can you help with item 1 and 2 in the above TODOs?

@zhengbuqian
Copy link
Collaborator Author

this issue is to track item 1, 2 and 4 only.

sre-ci-robot pushed a commit that referenced this issue Jun 6, 2024
issue: #29419
pr: #33209 

codecov will fail due to newly added ut in test_sealed.cpp skipped due
to #33210

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Copy link

stale bot commented Jun 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 21, 2024
@stale stale bot closed this as completed Jun 28, 2024
@zhengbuqian zhengbuqian reopened this Sep 10, 2024
@stale stale bot closed this as completed Sep 21, 2024
sre-ci-robot pushed a commit that referenced this issue Sep 28, 2024
issue: #33210

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Oct 8, 2024
issue: #33210

pr: #33622

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

2 participants