-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LegacyVersionWithoutRPCWatch default value to 2.4.1 #34184
Conversation
See also: milvus-io#31933 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
See also: milvus-io#31933 pr: milvus-io#34184 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34184 +/- ##
==========================================
- Coverage 81.01% 79.82% -1.20%
==========================================
Files 1077 1077
Lines 137194 137194
==========================================
- Hits 111153 109515 -1638
- Misses 21829 23458 +1629
- Partials 4212 4221 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…4184) See also: milvus-io#31933 --------- Signed-off-by: yangxuan <xuan.yang@zilliz.com>
See also: #31933