fix: LegacyVersionWithoutRPCWatch default value to 2.4.1 #34185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: milvus-io#31933 pr: milvus-io#34184 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
mergify
bot
added
dco-passed
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34185 +/- ##
==========================================
- Coverage 85.61% 82.05% -3.56%
==========================================
Files 761 1010 +249
Lines 107715 130782 +23067
==========================================
+ Hits 92222 107317 +15095
- Misses 11490 19480 +7990
+ Partials 4003 3985 -18
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Jul 12, 2024
Cherry-pick from 2.4 pr: milvus-io#33996 milvus-io#33940 milvus-io#34004 milvus-io#34020 milvus-io#34126 milvus-io#34185 milvus-io#34195 milvus-io#34210 milvus-io#34240 Co-authored-by: xige-16 <xige2016@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: sunby <sunbingyi1992@gmail.com> Co-authored-by: shaoting-huang <shaoting.huang@zilliz.com> Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
czs007
pushed a commit
that referenced
this pull request
Jul 13, 2024
Cherry-pick from 2.4 pr: #33996 #33940 #34004 #34020 #34126 #34185 #34195 #34210 #34240 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> Co-authored-by: xige-16 <xige2016@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: sunby <sunbingyi1992@gmail.com> Co-authored-by: shaoting-huang <shaoting.huang@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #31933
pr: #34184