Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Use deprecated error code in restful api cause access log panic. #34578

Closed
1 task done
aoiasd opened this issue Jul 10, 2024 · 2 comments
Closed
1 task done

[Bug]: Use deprecated error code in restful api cause access log panic. #34578

aoiasd opened this issue Jul 10, 2024 · 2 comments
Assignees
@aoiasd
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aoiasd
Copy link
Contributor

aoiasd commented Jul 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Some restful return error code by common.ErrorCode_Success not merr.Code(nil), may cause access log panic.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@aoiasd aoiasd added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 10, 2024
This was referenced Jul 10, 2024
Merged
Merged
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 10, 2024
@yanliang567
Copy link
Contributor

/assign @aoiasd
/unassign

@sre-ci-robot sre-ci-robot assigned aoiasd and unassigned yanliang567 Jul 10, 2024
sre-ci-robot pushed a commit that referenced this issue Jul 11, 2024
@aoiasd
fix: [Cherry-pick] Restful API use deprecate error code cause access …
d6fc6a9 
…log panic. (#34579)

Avoid panic when use deprecate error code and use merr code replace
deprecate common code.
relate: #34578
pr： #34576

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 12, 2024
@aoiasd
fix: Restful API use deprecate error code cause access log panic. (#3…
5bb0d21 
…4576)

relate: #34578

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
chyezh pushed a commit to chyezh/milvus that referenced this issue Jul 15, 2024
@aoiasd @chyezh
fix: Restful API use deprecate error code cause access log panic. (mi…
95aee70 
…lvus-io#34576)

relate: milvus-io#34578

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@stale Stale
Copy link

stale bot commented Aug 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 10, 2024
@stale stale bot closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoiasd aoiasd

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aoiasd @yanliang567