Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add segment level in SegmentInfo response struct #34746

Closed
1 task done
congqixia opened this issue Jul 17, 2024 · 0 comments
Closed
1 task done

[Enhancement]: Add segment level in SegmentInfo response struct #34746

congqixia opened this issue Jul 17, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Add segment level in SegmentInfo response struct

Why is this needed?

Segment Level is introduce in 2.4 and become more and more important. It's crucial to let observer, say Attu, to be able to known segment level info

Anything else?

No response
@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Jul 17, 2024
@congqixia congqixia self-assigned this Jul 17, 2024
congqixia added a commit to congqixia/milvus-proto that referenced this issue Jul 17, 2024
@congqixia
enhance: Add SegmentLevel in SegmentInfo response
9b47dfd 
See also milvus-io/milvus#34746

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 17, 2024
Merged
sre-ci-robot pushed a commit to milvus-io/milvus-proto that referenced this issue Jul 17, 2024
@congqixia
enhance: Add SegmentLevel in SegmentInfo response (#299)
3ffb1db 
See also milvus-io/milvus#34746

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 17, 2024
@congqixia
enhance: Add Segment Level in milvus segment info APIs
048c11a 
See also milvus-io#34746

This PR add segment level field in response of `GetPersistentSegmentInfo`
and `GetQuerySegmentInfo`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 17, 2024
Merged
congqixia added a commit to congqixia/milvus-proto that referenced this issue Jul 17, 2024
@congqixia
enhance: Add SegmentLevel in SegmentInfo response (milvus-io#299)
6a4a317 
See also milvus-io/milvus#34746

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 17, 2024
Merged
sre-ci-robot pushed a commit to milvus-io/milvus-proto that referenced this issue Jul 17, 2024
@congqixia
enhance: Add SegmentLevel in SegmentInfo response (#299) (#300)
5d85129 
See also milvus-io/milvus#34746

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 23, 2024
@congqixia
enhance: Add Segment Level in milvus segment info APIs
45bd67f 
See also milvus-io#34746

This PR add segment level field in response of `GetPersistentSegmentInfo`
and `GetQuerySegmentInfo`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 24, 2024
@congqixia
enhance: Add Segment Level in milvus segment info APIs
b9a978f 
See also milvus-io#34746

This PR add segment level field in response of `GetPersistentSegmentInfo`
and `GetQuerySegmentInfo`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 26, 2024
@congqixia
enhance: Add Segment Level in milvus segment info APIs (#34763)
4ee6c69 
See also #34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 26, 2024
@congqixia
enhance: Add Segment Level in milvus segment info APIs (milvus-io#34763)
f6f6156 
See also milvus-io#34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 29, 2024
@congqixia
enhance: [2.4] Add Segment Level in milvus segment info APIs (#34763) (…
d163207 
…#35023)

Cherry-pick from master
pr: #34763
See also #34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
enhance: Add Segment Level in milvus segment info APIs (milvus-io#34763)
0c23a2e 
See also milvus-io#34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia