Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cherry-pick] Change the fixed value to a ratio for clustering segment size #35075

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Jul 29, 2024

issue: #34495

master pr: #35076

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (cc188fb) to head (2118dcb).
Report is 9 commits behind head on 2.4.

Files Patch % Lines
internal/datacoord/compaction_trigger_v2.go 12.50% 6 Missing and 1 partial ⚠️
internal/datacoord/compaction_policy_clustering.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35075      +/-   ##
==========================================
+ Coverage   81.10%   81.12%   +0.01%     
==========================================
  Files        1051     1051              
  Lines      136692   136699       +7     
==========================================
+ Hits       110870   110892      +22     
+ Misses      21620    21610      -10     
+ Partials     4202     4197       -5     
Files Coverage Δ
internal/datacoord/task_analyze.go 85.95% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.53% <100.00%> (ø)
internal/datacoord/compaction_policy_clustering.go 52.77% <75.00%> (-0.60%) ⬇️
internal/datacoord/compaction_trigger_v2.go 71.72% <12.50%> (-1.51%) ⬇️

... and 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 30, 2024
@xiaocai2333
Copy link
Contributor Author

rerun ut

@binbinlv binbinlv added this to the 2.4.7 milestone Jul 30, 2024
@mergify mergify bot removed the ci-passed label Jul 30, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 31, 2024
@sre-ci-robot sre-ci-robot merged commit c340f38 into milvus-io:2.4 Jul 31, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants