Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Change the fixed value to a ratio for clustering segment size #35076

Merged
merged 2 commits into from
Aug 1, 2024
Merged

enhance: Change the fixed value to a ratio for clustering segment size #35076

merged 2 commits into from
Aug 1, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #34495

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 29, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Jul 29, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the fixed_value_to_ratio-m branch 2 times, most recently from e4f898c to 2c9aeef Compare July 31, 2024 01:57
sre-ci-robot pushed a commit that referenced this pull request Jul 31, 2024
@xiaocai2333
enhance: [cherry-pick] Change the fixed value to a ratio for clusteri…
c340f38 
…ng segment size (#35075)

issue: #34495 

master pr: #35076

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.28%. Comparing base (a642a26) to head (4a35b4d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #35076       +/-   ##
===========================================
- Coverage   81.54%   10.28%   -71.26%     
===========================================
  Files        1188      277      -911     
  Lines      142311    23885   -118426     
===========================================
- Hits       116047     2457   -113590     
+ Misses      21935    21428      -507     
+ Partials     4329        0     -4329

see 1175 files with indirect coverage changes

@xiaocai2333 xiaocai2333 mentioned this pull request Jul 31, 2024
Merged
@mergify mergify bot added the ci-passed label Jul 31, 2024
@xiaocai2333 xiaocai2333 added this to the 2.4.7 milestone Aug 1, 2024
@mergify mergify bot removed the ci-passed label Aug 1, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaocai2333
Change the fixed value to a ratio for clustering segment size
6c49d0c 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333
Support calculate segment maxRows with diskann
4a35b4d 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Aug 1, 2024
@binbinlv binbinlv removed this from the 2.4.7 milestone Aug 1, 2024
@mergify mergify bot added the ci-passed label Aug 1, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 1, 2024

/lgtm

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Aug 1, 2024
@sre-ci-robot sre-ci-robot merged commit 196a798 into milvus-io:master Aug 1, 2024
13 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
@xiaocai2333
enhance:[cherry-pick] Support calculate segment maxRows with diskann (#…
5f3d41d 
…35155)

issue: #34495 

master pr: #35076

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@xiaocai2333 @sumitd2
enhance: Change the fixed value to a ratio for clustering segment size (
8dc2603 
milvus-io#35076)

issue: milvus-io#34495

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
@xiaocai2333 xiaocai2333 deleted the fixed_value_to_ratio-m branch September 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @czs007 @sre-ci-robot @binbinlv