Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Check the job done, when all build index task finished, #384

Closed
JinHai-CN opened this issue Nov 18, 2019 · 0 comments
Closed

[BUG] Check the job done, when all build index task finished, #384

JinHai-CN opened this issue Nov 18, 2019 · 0 comments
Labels
good first issue Good for newcomers kind/bug Issues or changes related a bug

Comments

@JinHai-CN
Copy link
Contributor

Currently, once one build index task is finished. A condition variable notification will be sent to building job to check if job is done.

We should notify building job, when all build index task is finished but not one task.

In BuildIndexJob::BuildIndexDone function, before send notify_all out, we need to check if to_index_files_.empty() is true. Similar solution can be found in SearchJob::SearchDone.

@JinHai-CN JinHai-CN added kind/bug Issues or changes related a bug good first issue Good for newcomers labels Nov 18, 2019
jaime0815 pushed a commit to jaime0815/milvus that referenced this issue Nov 18, 2022
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
yah01 pushed a commit to yah01/milvus that referenced this issue Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Issues or changes related a bug
Projects
None yet
Development

No branches or pull requests

1 participant