Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen cpp codecov info #10072

Merged
merged 1 commit into from Oct 18, 2021
Merged

Gen cpp codecov info #10072

merged 1 commit into from Oct 18, 2021

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Oct 18, 2021

Signed-off-by: yhmo yihua.mo@zilliz.com

related: #7965

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #10072 (e701c2d) into master (ae5d2ee) will increase coverage by 0.01%.
The diff coverage is 97.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10072      +/-   ##
==========================================
+ Coverage   81.20%   81.22%   +0.01%     
==========================================
  Files         254      256       +2     
  Lines       46974    47089     +115     
==========================================
+ Hits        38147    38246      +99     
- Misses       6681     6693      +12     
- Partials     2146     2150       +4     
Impacted Files Coverage Δ
internal/datacoord/channel_store.go 82.53% <ø> (ø)
internal/datacoord/util.go 96.15% <ø> (ø)
internal/distributed/querynode/service.go 83.33% <ø> (ø)
internal/proxy/proxy.go 66.80% <ø> (ø)
internal/querycoord/task.go 84.97% <ø> (ø)
internal/rootcoord/meta_table.go 80.91% <ø> (ø)
internal/util/paramtable/param.go 71.01% <ø> (ø)
internal/proxy/task.go 72.56% <81.25%> (-0.03%) ⬇️
internal/datanode/flush_manager.go 100.00% <100.00%> (ø)
internal/datanode/flush_task.go 100.00% <100.00%> (ø)
... and 17 more

@mergify mergify bot added the ci-passed label Oct 18, 2021
@yhmo yhmo requested review from wxyucs and removed request for xige-16 and jeffoverflow October 18, 2021 04:03
@yhmo yhmo added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 18, 2021
@wxyucs
Copy link
Member

wxyucs commented Oct 18, 2021

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scsven, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c53f3b5 into milvus-io:master Oct 18, 2021
@yhmo yhmo deleted the ma branch October 18, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants