Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop alias error #12281

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix drop alias error #12281

merged 1 commit into from
Nov 25, 2021

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Nov 25, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
Copy link
Contributor Author

cydrain commented Nov 25, 2021

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Nov 25, 2021
@godchen0212
Copy link
Contributor

/lgtm

@wxyucs
Copy link
Member

wxyucs commented Nov 25, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #12281 (588f82e) into master (eb48013) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12281      +/-   ##
==========================================
- Coverage   78.93%   78.89%   -0.05%     
==========================================
  Files         449      449              
  Lines       60238    60239       +1     
==========================================
- Hits        47550    47523      -27     
- Misses      10190    10212      +22     
- Partials     2498     2504       +6     
Impacted Files Coverage Δ
internal/rootcoord/task.go 78.42% <100.00%> (+0.03%) ⬆️
internal/indexnode/indexnode_mock.go 79.61% <0.00%> (-5.34%) ⬇️
internal/querynode/tsafe_replica.go 93.68% <0.00%> (-3.16%) ⬇️
internal/querycoord/index_checker.go 71.90% <0.00%> (-2.39%) ⬇️
internal/datacoord/segment_manager.go 81.53% <0.00%> (-1.05%) ⬇️
internal/querycoord/query_coord.go 78.07% <0.00%> (-0.97%) ⬇️
internal/querynode/query_collection.go 81.68% <0.00%> (-0.54%) ⬇️
internal/datacoord/server.go 68.57% <0.00%> (-0.41%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 72.33% <0.00%> (-0.40%) ⬇️
internal/indexcoord/index_coord.go 77.02% <0.00%> (-0.33%) ⬇️
... and 5 more

@mergify mergify bot added the ci-passed label Nov 25, 2021
@sre-ci-robot sre-ci-robot merged commit 6188ac2 into milvus-io:master Nov 25, 2021
@cydrain cydrain deleted the caiyd_1125_1 branch November 25, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants