Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix similarity correlation #12511

Merged

Conversation

longjiquan
Copy link
Contributor

Signed-off-by: dragondriver jiquan.long@zilliz.com
/kind improvement
/cc @cydrain

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Dec 1, 2021
@mergify mergify bot added the dco-passed DCO check passed. label Dec 1, 2021
internal/proxy/task.go Outdated Show resolved Hide resolved
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
@cydrain
Copy link
Contributor

cydrain commented Dec 1, 2021

/lgtm

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #12511 (a43481f) into master (aa154e0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12511      +/-   ##
==========================================
+ Coverage   79.03%   79.05%   +0.02%     
==========================================
  Files         449      449              
  Lines       61272    61269       -3     
==========================================
+ Hits        48427    48437      +10     
+ Misses      10346    10333      -13     
  Partials     2499     2499              
Impacted Files Coverage Δ
internal/core/src/segcore/segment_c.cpp 63.26% <100.00%> (ø)
internal/proxy/task.go 73.75% <100.00%> (-0.01%) ⬇️
internal/util/distance/similarity_corelation.go 100.00% <100.00%> (ø)
internal/rootcoord/proxy_manager.go 62.14% <0.00%> (-2.86%) ⬇️
internal/datacoord/segment_manager.go 80.83% <0.00%> (-0.70%) ⬇️
internal/rootcoord/task.go 78.42% <0.00%> (-0.44%) ⬇️
internal/indexcoord/index_coord.go 77.17% <0.00%> (-0.33%) ⬇️
...where/knowhere/index/vector_index/impl/nsg/NSG.cpp 91.92% <0.00%> (-0.32%) ⬇️
internal/proxy/impl.go 77.60% <0.00%> (+0.15%) ⬆️
internal/querycoord/task.go 85.70% <0.00%> (+0.18%) ⬆️
... and 5 more

@longjiquan
Copy link
Contributor Author

rerun failure checks

@mergify mergify bot added the ci-passed label Dec 1, 2021
@wxyucs
Copy link
Member

wxyucs commented Dec 1, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DragonDriver, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1db1cf2 into milvus-io:master Dec 1, 2021
@longjiquan longjiquan deleted the fix-similarity-correlation branch December 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants