Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataType::bool cast to double #18690

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

congqixia
Copy link
Contributor

Related to #18624

/kind bug

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 17, 2022
@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Aug 17, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #18690 (989fb22) into master (d4c54d9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18690      +/-   ##
==========================================
- Coverage   82.45%   82.42%   -0.03%     
==========================================
  Files         520      520              
  Lines       80435    80435              
==========================================
- Hits        66319    66301      -18     
- Misses      11239    11256      +17     
- Partials     2877     2878       +1     
Impacted Files Coverage Δ
internal/core/src/segcore/Utils.cpp 74.28% <ø> (ø)
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/config/manager.go 83.59% <0.00%> (-1.59%) ⬇️
internal/datacoord/meta.go 87.53% <0.00%> (-0.65%) ⬇️
internal/querycoord/query_coord.go 76.82% <0.00%> (-0.57%) ⬇️
internal/proxy/impl.go 90.57% <0.00%> (-0.46%) ⬇️
internal/indexcoord/index_coord.go 81.00% <0.00%> (-0.42%) ⬇️
internal/datacoord/services.go 85.74% <0.00%> (-0.31%) ⬇️
internal/datacoord/segment_manager.go 85.04% <0.00%> (-0.28%) ⬇️
... and 5 more

@mergify mergify bot added the ci-passed label Aug 17, 2022
@czs007
Copy link
Contributor

czs007 commented Aug 17, 2022

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0db281c into milvus-io:master Aug 17, 2022
congqixia added a commit to congqixia/milvus that referenced this pull request Aug 17, 2022
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 17, 2022
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the fix_datatype_bool branch August 18, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants