Add all test cases #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
1 task
1 task
wayblink
referenced
this pull request
in wayblink/milvus
Aug 23, 2022
yhmo
pushed a commit
to yhmo/milvus
that referenced
this pull request
Aug 26, 2022
yhmo
added a commit
to yhmo/milvus
that referenced
this pull request
Sep 16, 2022
* Refine add segment logic for bulk load Also restructured `addNewSegment`, `addNormalSegment` and `addFlushedSegment` into a single `addSegment` to avoid duplicate code block and to see more clearly how adding these segments are different. /kind improvement Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Add garbage collection function for segments produced by partially failed imports (#6) Signed-off-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> * Enhance error handle in bulk load (#5) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine expiration/retention policy for import tasks (milvus-io#9) * Persist import task info to meta before update in memory (milvus-io#12) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Add start position for import segment (milvus-io#7) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine bulkload proto (milvus-io#11) Signed-off-by: groot <yihua.mo@zilliz.com> * Remove queryable/indexed logic and some other refinement (milvus-io#14) Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Resolve conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Some minor tweaks Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Implement CompleteBulkLoad feature (milvus-io#19) * Update interface and fix bug Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix dml start position mistake in AddSegmentReq (milvus-io#21) Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> * Fix getDmlChannelPositionByBroadcast (milvus-io#23) * Fix null start position issue Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix merge conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Bulkload enhancement (milvus-io#24) Signed-off-by: yhmo <yihua.mo@zilliz.com> * Add some unit tests Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: groot <yihua.mo@zilliz.com> Signed-off-by: yhmo <yihua.mo@zilliz.com> Co-authored-by: xing.zhao <34002927+EricStarer@users.noreply.github.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: wayblink <anyang.wang@zilliz.com> Co-authored-by: groot <yihua.mo@zilliz.com>
yhmo
added a commit
to yhmo/milvus
that referenced
this pull request
Sep 20, 2022
* Refine add segment logic for bulk load Also restructured `addNewSegment`, `addNormalSegment` and `addFlushedSegment` into a single `addSegment` to avoid duplicate code block and to see more clearly how adding these segments are different. /kind improvement Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Add garbage collection function for segments produced by partially failed imports (#6) Signed-off-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> * Enhance error handle in bulk load (#5) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine expiration/retention policy for import tasks (milvus-io#9) * Persist import task info to meta before update in memory (milvus-io#12) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Add start position for import segment (milvus-io#7) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine bulkload proto (milvus-io#11) Signed-off-by: groot <yihua.mo@zilliz.com> * Remove queryable/indexed logic and some other refinement (milvus-io#14) Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Resolve conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Some minor tweaks Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Implement CompleteBulkLoad feature (milvus-io#19) * Update interface and fix bug Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix dml start position mistake in AddSegmentReq (milvus-io#21) Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> * Fix getDmlChannelPositionByBroadcast (milvus-io#23) * Fix null start position issue Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix merge conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Bulkload enhancement (milvus-io#24) Signed-off-by: yhmo <yihua.mo@zilliz.com> * Add some unit tests Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: groot <yihua.mo@zilliz.com> Signed-off-by: yhmo <yihua.mo@zilliz.com> Co-authored-by: xing.zhao <34002927+EricStarer@users.noreply.github.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: wayblink <anyang.wang@zilliz.com> Co-authored-by: groot <yihua.mo@zilliz.com>
wayblink
referenced
this pull request
in wayblink/milvus
Sep 22, 2022
* Refine add segment logic for bulk load Also restructured `addNewSegment`, `addNormalSegment` and `addFlushedSegment` into a single `addSegment` to avoid duplicate code block and to see more clearly how adding these segments are different. /kind improvement Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Add garbage collection function for segments produced by partially failed imports (#6) Signed-off-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> * Enhance error handle in bulk load (#5) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine expiration/retention policy for import tasks (#9) * Persist import task info to meta before update in memory (#12) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Add start position for import segment (#7) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine bulkload proto (#11) Signed-off-by: groot <yihua.mo@zilliz.com> * Remove queryable/indexed logic and some other refinement (#14) Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Resolve conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Some minor tweaks Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Implement CompleteBulkLoad feature (#19) * Update interface and fix bug Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix dml start position mistake in AddSegmentReq (#21) Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> * Fix getDmlChannelPositionByBroadcast (#23) * Fix null start position issue Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix merge conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Bulkload enhancement (#24) Signed-off-by: yhmo <yihua.mo@zilliz.com> * Add some unit tests Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: groot <yihua.mo@zilliz.com> Signed-off-by: yhmo <yihua.mo@zilliz.com> Co-authored-by: xing.zhao <34002927+EricStarer@users.noreply.github.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: wayblink <anyang.wang@zilliz.com> Co-authored-by: groot <yihua.mo@zilliz.com>
yhmo
added a commit
to yhmo/milvus
that referenced
this pull request
Sep 23, 2022
* Refine add segment logic for bulk load Also restructured `addNewSegment`, `addNormalSegment` and `addFlushedSegment` into a single `addSegment` to avoid duplicate code block and to see more clearly how adding these segments are different. /kind improvement Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Add garbage collection function for segments produced by partially failed imports (#6) Signed-off-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> * Enhance error handle in bulk load (#5) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine expiration/retention policy for import tasks (milvus-io#9) * Persist import task info to meta before update in memory (milvus-io#12) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Add start position for import segment (milvus-io#7) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine bulkload proto (milvus-io#11) Signed-off-by: groot <yihua.mo@zilliz.com> * Remove queryable/indexed logic and some other refinement (milvus-io#14) Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Resolve conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Some minor tweaks Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Implement CompleteBulkLoad feature (milvus-io#19) * Update interface and fix bug Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix dml start position mistake in AddSegmentReq (milvus-io#21) Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> * Fix getDmlChannelPositionByBroadcast (milvus-io#23) * Fix null start position issue Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix merge conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Bulkload enhancement (milvus-io#24) Signed-off-by: yhmo <yihua.mo@zilliz.com> * Add some unit tests Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: groot <yihua.mo@zilliz.com> Signed-off-by: yhmo <yihua.mo@zilliz.com> Co-authored-by: xing.zhao <34002927+EricStarer@users.noreply.github.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: wayblink <anyang.wang@zilliz.com> Co-authored-by: groot <yihua.mo@zilliz.com>
yhmo
added a commit
to yhmo/milvus
that referenced
this pull request
Sep 24, 2022
* Refine add segment logic for bulk load Also restructured `addNewSegment`, `addNormalSegment` and `addFlushedSegment` into a single `addSegment` to avoid duplicate code block and to see more clearly how adding these segments are different. /kind improvement Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Add garbage collection function for segments produced by partially failed imports (#6) Signed-off-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> * Enhance error handle in bulk load (#5) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine expiration/retention policy for import tasks (milvus-io#9) * Persist import task info to meta before update in memory (milvus-io#12) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Add start position for import segment (milvus-io#7) Signed-off-by: wayblink <anyang.wang@zilliz.com> * Refine bulkload proto (milvus-io#11) Signed-off-by: groot <yihua.mo@zilliz.com> * Remove queryable/indexed logic and some other refinement (milvus-io#14) Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Resolve conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Some minor tweaks Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Implement CompleteBulkLoad feature (milvus-io#19) * Update interface and fix bug Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix dml start position mistake in AddSegmentReq (milvus-io#21) Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> * Fix getDmlChannelPositionByBroadcast (milvus-io#23) * Fix null start position issue Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix merge conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Fix conflicts Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> * Bulkload enhancement (milvus-io#24) Signed-off-by: yhmo <yihua.mo@zilliz.com> * Add some unit tests Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com> Signed-off-by: wayblink <anyang.wang@zilliz.com> Signed-off-by: groot <yihua.mo@zilliz.com> Signed-off-by: yhmo <yihua.mo@zilliz.com> Co-authored-by: xing.zhao <34002927+EricStarer@users.noreply.github.com> Co-authored-by: xingzhao <xing.zhao@zilliz.com> Co-authored-by: wayblink <anyang.wang@zilliz.com> Co-authored-by: groot <yihua.mo@zilliz.com>
yah01
pushed a commit
to yah01/milvus
that referenced
this pull request
Feb 13, 2023
1 task
1 task
1 task
MrPresent-Han
pushed a commit
to MrPresent-Han/milvus
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18