Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster dev 3 #12

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Cluster dev 3 #12

wants to merge 39 commits into from

Conversation

wayblink
Copy link
Owner

No description provided.

@wayblink wayblink force-pushed the cluster-dev-3 branch 10 times, most recently from ecbf3a7 to 419d6ac Compare December 26, 2023 13:00
wayblink and others added 20 commits January 4, 2024 19:22
related: milvus-io/milvus-proto#233
issue: milvus-io#29593
/kind enhancement

Signed-off-by: wayblink <anyang.wang@zilliz.com>
issue: milvus-io#29292

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: sre-ci-robot <sre-ci-robot@zilliz.com>
See also milvus-io#27675

`Allocator.Alloc` and `Allocator.AllocOne` might be invoked multiple
times if there were multiple blobs set in one sync task.

This PR add pre-fetch logic for all blobs and cache logIDs in sync task
so that at most only one call of the allocator is needed.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
See also milvus-io#29699

Querycoord panicked when tried to pop from an empty heap. We assume the
heap shall not be empty, but in some branch, the candidate is never
pushed back.

This PR put pop & push in a closure and adds a defer call to push item
back.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This PR defines the new import reader interfaces and implement a binlog
reader for import.

issue: milvus-io#28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This PR add ctx for load index logs

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
issue: milvus-io#29672
the storage account need privileges of actions
`Microsoft.Storage/storageAccounts/blobServices/containers/blobs/*` at
least

Signed-off-by: PowderLi <min.li@zilliz.com>
milvus-io#29590)

issue: milvus-io#29230
this pr do these things:
1. add gpu brute force;
2. limit gpu index only support l2 / ip;

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
…28983)

related: milvus-io#25324

Search GroupBy function, used to aggregate result entities based on a
specific scalar column.
several points to mention:

1. Temporarliy, the whole groupby is implemented separated from
iterative expr framework **for the first period**
2. In the long term, the groupBy operation will be incorporated into the
iterative expr framework:milvus-io#28166
3. This pr includes some unrelated mocked interface regarding alterIndex
due to some unworth-to-mention reasons. All these un-associated content
will be removed before the final pr is merged. This version of pr is
only for review
4. All other related details were commented in the files comparison

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
issue: milvus-io#29453 

sync distribution by rpc will also call loadSegment/releaseSegment,
which may cause all kinds of concurrent case on same segment, such as
concurrent load and release on one segment.
This PR add leader_checker which generate load/release task to correct
the leader view, instead of calling sync distribution by rpc

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
due to `clientMaxSendSize` and `serverMaxRecvSize` will limit the rpc
request size limit, they should use same config value, and
`serverMaxSendSize` and `clientMaxRecvSize` will limit the rpc response
size limit, they should use same config value too.

This PR fix unexpected rpc msg limit which caused by the wrong usage of
misunderstanding rpc config items

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
related milvus-io#29588

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
relate: milvus-io#29645

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
This PR implements a new json reader for import.

issue: milvus-io#28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
fix milvus-io#29642

Signed-off-by: yah01 <yang.cen@zilliz.com>
Resolves: milvus-io#29736

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
issue: milvus-io#29697

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
bigsheeper and others added 9 commits January 7, 2024 19:38
This PR implements a Parquet reader for import.

issue: milvus-io#28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
milvus-io#28410
/kind feature

Signed-off-by: wayblink <anyang.wang@zilliz.com>
…#29627)

related to : milvus-io#29417 

cardinal indexes upload index files in `Serialize` interface, and throw
exception when the `Serialize` failed.

Signed-off-by: xianliang <xianliang.li@zilliz.com>
fix: milvus-io#29585

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
fix: milvus-io#29349

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
milvus-io#26137

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
This pr will make milvus load delta logs concurrently, which should
decrease the latency of loading a segment.
/kind improvement

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
issue: milvus-io#29654

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@wayblink wayblink force-pushed the cluster-dev-3 branch 2 times, most recently from 608949f to dbc95c9 Compare January 8, 2024 06:15
congqixia and others added 4 commits January 8, 2024 14:16
…ilvus-io#29740)

See also milvus-io#27349

The segment level label in querynode used `Legacy` before segment level
was correctly passed in Load request. Now this attribute is still using
legacy so the metrics does not look right.

This PR add paramter for `NewSegment` and passes corrent values for each
invocation.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
…9747)

Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: milvus-io#29710

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
issue milvus-io#25639 

Signed-off-by: xige-16 <xi.ge@zilliz.com>

Signed-off-by: xige-16 <xi.ge@zilliz.com>
this avoids the conflicts while running multiple unit tests

Signed-off-by: yah01 <yah2er0ne@outlook.com>
XuanYang-cn and others added 6 commits January 8, 2024 17:46
See also: milvus-io#29447

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This PR implements a new numpy reader for import.

issue: milvus-io#28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…29771)

Resolves: milvus-io#29770

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet