Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether segments are fully loaded while fetching shard leaders #20991

Merged
merged 1 commit into from Dec 6, 2022

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 5, 2022

Signed-off-by: yah01 yang.cen@zilliz.com
/kind bug
related #20841

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 5, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 5, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #20991 (3cbac4c) into master (243d8cf) will increase coverage by 0.03%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20991      +/-   ##
==========================================
+ Coverage   81.75%   81.79%   +0.03%     
==========================================
  Files         693      697       +4     
  Lines       93318    93686     +368     
==========================================
+ Hits        76293    76629     +336     
- Misses      14005    14027      +22     
- Partials     3020     3030      +10     
Impacted Files Coverage Δ
internal/querycoordv2/services.go 82.44% <94.73%> (+2.71%) ⬆️
internal/querycoordv2/job/scheduler.go 88.42% <0.00%> (-6.32%) ⬇️
internal/rootcoord/scheduler.go 96.29% <0.00%> (-3.71%) ⬇️
internal/querycoordv2/dist/dist_handler.go 74.57% <0.00%> (-3.39%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-2.55%) ⬇️
internal/config/manager.go 76.02% <0.00%> (-1.54%) ⬇️
internal/distributed/querycoord/client/client.go 79.02% <0.00%> (-1.40%) ⬇️
internal/indexcoord/flush_segment_watcher.go 95.88% <0.00%> (-1.24%) ⬇️
internal/distributed/datacoord/client/client.go 75.34% <0.00%> (-0.80%) ⬇️
internal/querycoordv2/checkers/segment_checker.go 84.89% <0.00%> (-0.53%) ⬇️
... and 26 more

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 11e4445 into milvus-io:master Dec 6, 2022
yah01 added a commit to yah01/milvus that referenced this pull request Dec 12, 2022
sre-ci-robot pushed a commit that referenced this pull request Dec 12, 2022
…20991) (#21139)

Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants