Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether segments are fully loaded while fetching shard leaders (#20991) #21139

Merged
merged 1 commit into from Dec 12, 2022

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 12, 2022

Signed-off-by: yah01 yang.cen@zilliz.com

/kind bug
related #20841

see also #20991

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 12, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 12, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #21139 (49684c8) into 2.2.0 (f209c9c) will increase coverage by 0.04%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #21139      +/-   ##
==========================================
+ Coverage   82.02%   82.06%   +0.04%     
==========================================
  Files         688      689       +1     
  Lines       93182    93257      +75     
==========================================
+ Hits        76430    76530     +100     
+ Misses      13749    13737      -12     
+ Partials     3003     2990      -13     
Impacted Files Coverage Δ
internal/querycoordv2/services.go 82.50% <79.31%> (+2.03%) ⬆️
internal/querycoordv2/errors.go 100.00% <100.00%> (ø)
internal/querycoordv2/dist/dist_handler.go 71.71% <0.00%> (-5.93%) ⬇️
internal/querynode/validate.go 75.90% <0.00%> (-1.63%) ⬇️
internal/querynode/impl.go 64.66% <0.00%> (-1.31%) ⬇️
internal/indexcoord/flush_segment_watcher.go 95.90% <0.00%> (-1.23%) ⬇️
internal/distributed/querynode/client/client.go 89.81% <0.00%> (-1.14%) ⬇️
internal/datanode/flow_graph_insert_buffer_node.go 92.43% <0.00%> (-1.13%) ⬇️
internal/querynode/query_node.go 80.61% <0.00%> (-1.03%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.50% <0.00%> (-1.00%) ⬇️
... and 23 more

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 12, 2022
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 12, 2022
@mergify mergify bot removed the ci-passed label Dec 12, 2022
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit df8c67f into milvus-io:2.2.0 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants