Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill collection schema after DataCoord restarts #21161

Merged
merged 1 commit into from Dec 12, 2022

Conversation

congqixia
Copy link
Contributor

Fix #21160

/kind bug

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 12, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Dec 12, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #21161 (abd72f8) into master (b0afdb2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21161      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.02%     
==========================================
  Files         706      706              
  Lines       95050    95051       +1     
==========================================
- Hits        78050    78039      -11     
- Misses      14007    14018      +11     
- Partials     2993     2994       +1     
Impacted Files Coverage Δ
internal/datacoord/channel_store.go 85.32% <100.00%> (+0.06%) ⬆️
internal/config/refresher.go 71.05% <0.00%> (-7.90%) ⬇️
internal/querycoordv2/job/scheduler.go 88.42% <0.00%> (-6.32%) ⬇️
internal/rootcoord/scheduler.go 96.29% <0.00%> (-3.71%) ⬇️
internal/querycoordv2/task/scheduler.go 78.23% <0.00%> (-1.38%) ⬇️
internal/querycoordv2/task/executor.go 73.69% <0.00%> (-0.87%) ⬇️
internal/indexcoord/index_coord.go 75.80% <0.00%> (-0.59%) ⬇️
internal/querynode/impl.go 66.02% <0.00%> (-0.17%) ⬇️
internal/indexcoord/meta_table.go 96.07% <0.00%> (+0.36%) ⬆️
internal/datacoord/server.go 78.13% <0.00%> (+0.70%) ⬆️
... and 3 more

@mergify mergify bot added the ci-passed label Dec 12, 2022
@yah01
Copy link
Member

yah01 commented Dec 12, 2022

/lgtm

@sre-ci-robot sre-ci-robot merged commit 53782ab into milvus-io:master Dec 12, 2022
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 12, 2022
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 12, 2022
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DataCoord lost channel watch schema info after restart
3 participants