Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry Pick] Fill collection schema after DataCoord restarts (#21161) #21164

Merged
merged 1 commit into from Dec 12, 2022

Conversation

congqixia
Copy link
Contributor

Fix #21160

/kind bug

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 12, 2022
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Dec 12, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #21164 (643524c) into 2.2.0 (124ff01) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            2.2.0   #21164   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files         688      688           
  Lines       93227    93228    +1     
=======================================
+ Hits        76437    76440    +3     
+ Misses      13786    13782    -4     
- Partials     3004     3006    +2     
Impacted Files Coverage Δ
internal/datacoord/channel_store.go 85.18% <100.00%> (+0.06%) ⬆️
internal/kv/rocksdb/RocksIterator.go 72.09% <0.00%> (-6.98%) ⬇️
internal/rootcoord/scheduler.go 96.29% <0.00%> (-3.71%) ⬇️
internal/indexcoord/flush_segment_watcher.go 95.90% <0.00%> (-1.23%) ⬇️
internal/querynode/query_node.go 80.61% <0.00%> (-1.03%) ⬇️
internal/log/zap_text_encoder.go 83.64% <0.00%> (-0.71%) ⬇️
internal/datacoord/server.go 77.73% <0.00%> (-0.70%) ⬇️
internal/datanode/data_node.go 77.15% <0.00%> (-0.63%) ⬇️
internal/datacoord/session_manager.go 83.24% <0.00%> (-0.51%) ⬇️
internal/indexcoord/meta_table.go 95.70% <0.00%> (-0.37%) ⬇️
... and 6 more

@mergify mergify bot added the ci-passed label Dec 12, 2022
@sre-ci-robot sre-ci-robot merged commit 0dc9a03 into milvus-io:2.2.0 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants